Block Editor: Bail out of hasSelectedInnerBlock when there is no clientId - #81315
Merged
Conversation
Mamaduka
added
[Type] Code Quality
Mamaduka
force-pushed
the
fix/has-selected-inner-block-selector
branch
from
August 7, 2026 07:05
ffbe4d5 to
5fe0d0d
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Mamaduka
force-pushed
the
fix/has-selected-inner-block-selector
branch
from
August 7, 2026 07:05
5fe0d0d to
eae1ed7
Compare
|
Size Change: +1 B (0%) Total Size: 7.82 MB 📦 View Changed
|
im3dabasia
approved these changes
Aug 7, 2026
im3dabasia
left a comment
im3dabasia
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the PR!
✅ LGTM
Mamaduka
force-pushed
the
fix/has-selected-inner-block-selector
branch
from
August 7, 2026 08:38
eae1ed7 to
72c59ed
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Related #81210 and #81212
A small code quality improvement, after I realized it's better to handle this case in the selector 😅
hasSelectedInnerBlockreturnedfalsefor a missing client ID, but only after reading the selection and either walking it or checking it against the ancestor set. Neither can ever match, so returnfalseup front instead.This also fixes the root client ID (
''), which the shallow check reported astruewhenever any top-level block was selected, while the deep check reportedfalse. Both now returnfalse. No caller passes''today.I've also cleaned up checks from #81210.
Testing Instructions
CI checks are green.
Use of AI Tools
Assisted by Claude.